improve processConnectAuthSuccess behaviour #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the behavior of the processConnectAuthSuccess function by changing its return type from void to a discriminated union that indicates success/failure status. The function now returns a success object with the identity or a failure object with an error message.
- Changed
processConnectAuthSuccessto return success/failure result objects instead of void - Replaced alert() calls with proper error returns within the authentication function
- Updated all authentication callback components to handle the new return type and display errors appropriately
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/hypergraph-react/src/HypergraphAppContext.tsx | Updated function signature and implementation to return success/error objects |
| docs/docs/authentication.md | Updated documentation example to handle new return type |
| apps/template-vite-react/src/routes/authenticate-success.tsx | Updated to handle new return type and prevent duplicate processing |
| apps/template-nextjs/Components/Login/AuthCallback.tsx | Updated to handle new return type and prevent duplicate processing |
| apps/privy-login-example/src/routes/authenticate-success.tsx | Updated to handle new return type and prevent duplicate processing |
| apps/events/src/routes/authenticate-success.tsx | Updated to handle new return type and prevent duplicate processing |
| .changeset/cuddly-guests-hug.md | Added changeset documenting the improvement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nikgraf
force-pushed
the
ng/bug-fixes
branch
from
2f7957f to
b1403c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.